Promoting sepolia account to admin. #1651
Conversation
WalkthroughThe recent update involves a modification to a deployment script for a testnet, specifically for a Layer 1 contract. The script now includes a function call that grants admin privileges to two new addresses within the Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| // Deploy a constant supply (constructor mints) erc20 | ||
| await deployments.execute('ObscuroBridge', { | ||
| from: deployer | ||
| }, 'promoteToAdmin', '0xE09a37ABc1A63441404007019E5BC7517bE2c43f') | ||
| }, 'promoteToAdmin', '0xE09a37ABc1A63441404007019E5BC7517bE2c43f'); | ||
|
|
||
| await deployments.execute('ObscuroBridge', { | ||
| from: deployer | ||
| }, 'promoteToAdmin', '0xeC3f9B38a3B30AdC9fB3dF3a0D8f50127E6c2C8f'); | ||
| }; | ||
|
|
There was a problem hiding this comment.
The changes introduce a new administrative function to promote two Ethereum addresses to admin status within the ObscuroBridge contract. Ensure that the addresses '0xE09a37ABc1A63441404007019E5BC7517bE2c43f' and '0xeC3f9B38a3B30AdC9fB3dF3a0D8f50127E6c2C8f' are correct and intended to be granted admin rights. Additionally, confirm that the promoteToAdmin function has been properly tested and audited, especially since it involves privilege escalation which can be a sensitive change in terms of security.
Also, verify that the deployments.execute function has appropriate error handling in case the transaction fails, and consider the implications of transaction ordering, in case these promotions need to occur in a specific sequence or atomic transaction.
Lastly, ensure that the function promoteToAdmin is secure and does not introduce any vulnerabilities, such as the potential for unauthorized privilege escalation, and that its use is compliant with the overall governance and security policies of the project.
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks
Summary by CodeRabbit